-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Windows SDK UCRT DLL paths for jdk17+ pipeline configuration #811
Conversation
…d version Signed-off-by: Andrew Leonard <anleonar@redhat.com>
…d version Signed-off-by: Andrew Leonard <anleonar@redhat.com>
…d version Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
run tests |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run tests |
PR TESTER RESULT ✅ All pipelines passed! ✅ |
Related adoptium#811 runtimes infra 8378 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
…doptium#811) * Add jdk17+ pipeline configuration for --with-ucrt-dll-dir location and version Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Add jdk17+ pipeline configuration for --with-ucrt-dll-dir location and version Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Add jdk17+ pipeline configuration for --with-ucrt-dll-dir location and version Signed-off-by: Andrew Leonard <anleonar@redhat.com> --------- Signed-off-by: Andrew Leonard <anleonar@redhat.com>
To ensure a managed and thus deterministic Windows SDK DLLs for jdk-17+ JDKs, specify --with-ucrt-dll-dir=.
The standard Windows SDK version 10.0.22000.0 UCRT DLLs used with VS2019 are located in:
Fixes adoptium/temurin-build#3479