Using credentials for release tool job #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@3df4ab1...8ade135) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
smlambert
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Minor comment change request, otherwise LGTM, thanks @sophia-guo !
karianna
requested changes
Oct 5, 2023
Jenkinsfile
Outdated
| withEnv(["GITHUB_TOKEN=${secretToken}"]) { | ||
| sh ''' | ||
| export VERSION=`echo $VERSION | awk '{print toupper($0)}'` | ||
| JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 ./sbin/Release.sh |
There was a problem hiding this comment.
Can we rely on a more modern Java here?
There was a problem hiding this comment.
This is the java the current job is using https://ci.adoptium.net/job/build-scripts/job/release/job/refactor_openjdk_release_tool/. Which modern java is available and can be used in https://ci.adoptium.net/computer/C3jenkins/? @sxa
There was a problem hiding this comment.
There is /usr/lib/jvm/java-17-openjdk-amd64 on that machine, but we could install another version if desired.
There was a problem hiding this comment.
@karianna update to jdk17, thanks!
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
smlambert
changed the title
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
karianna
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #126
Jenkins new job https://ci.adoptium.net/job/refactor_openjdk_release_tool_new/
Signed-off-by: Sophia Guo sophia.gwf@gmail.com