Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK17 requires gradle 7.3 #143

Merged
merged 1 commit into from
Nov 17, 2023
Merged

JDK17 requires gradle 7.3 #143

merged 1 commit into from
Nov 17, 2023

Conversation

sophia-guo
Copy link
Contributor

Fix #142

Signed-off-by: Sophia Guo sophia.gwf@gmail.com

@karianna
Copy link
Contributor

The build script will need refactoring as Gradle 7.3 removed some old syntax

@sophia-guo sophia-guo marked this pull request as draft November 14, 2023 20:05
@sophia-guo
JDK17 requires gradle 7.3
dd747d0 
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo sophia-guo self-assigned this Nov 15, 2023
@sophia-guo sophia-guo marked this pull request as ready for review November 15, 2023 20:15
@sophia-guo
Copy link
Contributor Author

@sxa

sxa
sxa approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the assumption that you have tested that it works :-)

@karianna karianna merged commit 4a57826 into adoptium:master Nov 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@sxa sxa sxa approved these changes

Assignees

@sophia-guo sophia-guo

Labels
None yet
Projects
No open projects
Adoptium 4Q 2023 Plan
Status: Done
Milestone
No milestone
3 participants
@sophia-guo @karianna @sxa