Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: switch alpine builds to use temurin boot jdk where possible #2568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gdams
Copy link
Member

@gdams gdams commented May 19, 2022

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

JDK19_BOOT_DIR="/usr/lib/jvm/zulu18" \
JDKLATEST_BOOT_DIR="/usr/lib/jvm/zulu18" \
JAVA_HOME="/usr/lib/jvm/zulu8"
JDK7_BOOT_DIR="/usr/lib/jvm/jdk-7" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one going to be pointing anywhere useful? I'd be tempted to hold off a bit on these changes until we've verified they work properly. I get the impression the JDK11 in particular may be causing the hangs on the test jobs as some of the later versions don't seem to be freezing so much at the moment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I switched the Zulu 7 build to be installed there for now

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted this PR as not having been merged. I'm having a look at it and it looks like it's trying to symlink zulu into /usr/lib/jvm/jdk-xx, yet it removes the zulu downloads.

Also the - ansible_distribution != "Alpine" in the top level for the adoptopenjdk_install role seems to actively stop it trying to install the Temurin JDKs on Alpine. Am I missing something?

@karianna
Copy link
Contributor

@gdams Will need a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants