Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unixPb: Remove task to uninstall libpng #3254

Merged
merged 1 commit into from
Nov 16, 2023
Merged

unixPb: Remove task to uninstall libpng #3254

merged 1 commit into from
Nov 16, 2023

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Nov 16, 2023 •
edited
Loading

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Now that adoptium/temurin-build#3509 is solved and adoptium/temurin-build#3523 was merged we can remove the task which uninstalls libpng from our mac machines as the build will now know to not pick up libpng

@Haroon-Khel Haroon-Khel requested a review from sxa November 16, 2023 11:47
@Haroon-Khel Haroon-Khel mentioned this pull request Nov 16, 2023
Closed
steelhead31
steelhead31 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sxa
sxa approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍🏻
This will be good as we start moving to Orka provisioned machines at MacStadium for building. The final part of the switchover to building the x64 builds on aarch64 machines!

@Haroon-Khel Haroon-Khel merged commit 8519a18 into adoptium:master Nov 16, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steelhead31 steelhead31 steelhead31 approved these changes

@sxa sxa sxa approved these changes

Assignees
No one assigned
Labels
ansible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Haroon-Khel @sxa @steelhead31