Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing changelog changes #1040

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Add missing changelog changes #1040

merged 4 commits into from
Oct 30, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Oct 29, 2024 •
edited
Loading

  • changelog changes were missing, and it is these that determine the build target filenames (!)

Test publish using this branch: https://ci.adoptium.net/job/adoptium-packages-linux-pipeline_new/1648/

@andrew-m-leonard
Oct 2024 release linux changelogs
d6d9aeb 
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Oct 2024 release linux changelogs
635a047 
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Oct 2024 release linux changelogs
b7c9a98 
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard andrew-m-leonard self-assigned this Oct 29, 2024
@andrew-m-leonard andrew-m-leonard requested review from gdams and sxa October 29, 2024 16:46
adamfarley
adamfarley approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sxa
sxa reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not necessarily recommend we run things related to build process on the set of machines that this will match not least because many of them are running old distributions.

I suspect we should just enable the x64 label on dockerhost-azure-ubuntu2204-x64-1 (Not quite sure why it was disabled and replaced with removed-x64)

@andrew-m-leonard
Oct 2024 release linux changelogs
f1259bd 
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard andrew-m-leonard changed the title Add missing changelog changes and fix installer linux node deadlock Add missing changelog changes Oct 30, 2024
@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Oct 30, 2024 •
edited
Loading

Agree @sxa thanks for finding that old node, I presume it was removed as it's 2204(?), i've brought it back online for use, to resolve the deadlock here.

The installer upload jfrog-cli issue I have raised here: #1042 which is due to the pipeline using combined Declarative & Scripted syntax.

For the moment we need to temporarily remove dockerBuild from the Azure Cloud Linux-build VMs in order to run the installer uploads...

@sxa
Copy link
Member

sxa commented Oct 30, 2024

For the moment we need to temporarily "disable" the Azure Cloud Linux-build VMs in order to run the installer uploads...

So removing dockerBuild wasn't enough?

@andrew-m-leonard
Copy link
Contributor Author

For the moment we need to temporarily "disable" the Azure Cloud Linux-build VMs in order to run the installer uploads...

So removing dockerBuild wasn't enough?

yeah it was, wrong words!

@andrew-m-leonard andrew-m-leonard merged commit c3406a7 into adoptium:master Oct 30, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa left review comments

@adamfarley adamfarley adamfarley approved these changes

@gdams gdams gdams approved these changes

Assignees

@andrew-m-leonard andrew-m-leonard

Labels
None yet
Projects
2024 4Q Adoptium Plan
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrew-m-leonard @sxa @gdams @adamfarley