-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate libfreetype install on JDK21 #812
Conversation
Signed-off-by: Stewart X Addison <sxa@redhat.com>
CC @joe-braley @d3r3kk to see if we need to do the same for MSFT installers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unable to test due to: adoptium/infrastructure#3362 |
Running a test here: https://ci.adoptium.net/job/adoptium-packages-linux-pipeline_new/1201/ |
Could not compile settings file '/home/jenkins/workspace/adoptium-packages-linux-pipeline_new/linuxRedHat/settings.gradle'.
Looks like a 'Code was compiled with Java version X vs being run as Java version Y problem |
That is correct, although I'm surprised it hit it in this run because I mitigated that yesterday by changing the default https://ci.adoptium.net/job/adoptium-packages-linux-pipeline_new/1202/ is a re-run of Andrew's earlier job on aarch64 instead of x86-64 so will be a better test. I'll try and look at why that (new) machine is misbehaving tomorrow. |
That didn't work. Apparently the packaging job is forcing itself to run on an x64 docker host
so even using the parameter to build for aarch64 it was still being scheduled on the new machine. I've re-enabled an equinix machine temporarily so we can test this on a known-working configuration - it's at https://ci.adoptium.net/job/adoptium-packages-linux-pipeline_new/1203/console |
That ran green. It's past midnight for me so I've locked the job so the output won't get deleted and we can do some verification / comparison with the GA builds tomorrow (If anyone wants to do so before I go for it then, of course, feel free :-) ) |
Confirmed that the aarch64 deb and rpm archives from job 1203 linked above are identical other than the presence of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Merging, noting that the Alpine apk has the |
Fixes adoptium/temurin-build#3624 (comment) (hopefully!)
Note that I haven't adjusted
redhat/src/main/packaging/microsoft/21/msopenjdk-21.spec
which still has therm
I have not tested this, so if a review can fdire off a test and see if the package contains
libfreetype.so
after this then that would be appreciated.