Skip to content

Commit

Permalink
Fix TODO.
Browse files Browse the repository at this point in the history
  • Loading branch information
netomi committed Nov 6, 2023
1 parent 4ca6275 commit 38d58f0
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions tooling/release_download_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,12 @@ tar -C tarballtest --strip-components=1 -xzpf OpenJDK*-jdk_"${ARCH}"_"${OS}"_hot
##########################################################################################################################
#
# Verify GLIBC and GCC version of the release matching the OS/ARCH on which this script is running.
# TODO: this should actually not only check the release matching the OS/ARCH but rather test all.
# I tested the OpenJDK21U-jdk_x64_linux_hotspot_21.0.1_12.tar.gz release and the GLIBC version used to build it is: GLIBC_2.2.5
# Currently only linux-aarch64 seems to be handled correctly.
#
# TODO: this should actually not only check the binary matching the OS/ARCH but rather test all.
# I tested the OpenJDK21U-jdk_x64_linux_hotspot_21.0.1_12.tar.gz binary and the GLIBC version
# used to build it is: GLIBC_2.2.5
# Currently only linux-aarch64 seems to be handled correctly for some jdk version.
#
##########################################################################################################################

print_verbose "IVT : Detected GLIBC version '$(strings tarballtest/bin/java | grep ^GLIBC)'"
Expand Down

0 comments on commit 38d58f0

Please sign in to comment.