Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OpenJ9 CUDA support if the SDK is installed on aarch64 #2855

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sxa
Copy link
Member

@sxa sxa commented Feb 23, 2022

We don't enable this as a matter of course, since our cloud machines do not have the CUDA development kit installed, but for anyone that has the CUDA 10.2 toolkit installed on a device such as the Jetson Nano (thread), this will enable the CUDA support to be built into OpenJ9.

Signed-off-by: Stewart X Addison sxa@redhat.com

@sxa sxa self-assigned this Feb 23, 2022
@github-actions github-actions bot added aarch Issues that affect or relate to the aarch ARCHITECTURE macos Issues that affect or relate to the MAC OS labels Feb 23, 2022
@sxa
Copy link
Member Author

sxa commented Mar 8, 2023

This is a year old and seems to work (presumably it hasn't been reviewed because it was in draft while it underwent testing) so it would be good to push it in if no-one objects - tagging @andrew-m-leonard
@AdamBrousseau @keithc-ca Any objections to enabling this to be picked up in our build scripts if it exists on aarch64? I seem to remember someone else in the J9 team possibly had one of the devices too so it would be good to allow it to be picked up if someone is using our scripts on a Jetson.

@sxa sxa marked this pull request as ready for review March 8, 2023 17:04
@keithc-ca
Copy link
Contributor

I didn't look, but I would hope there's a way to arrange to use a different version, i.e. the hard-coded path doesn't override an explicitly specified --with-code=/some/other/location. Other than that, I have no objections.

@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels May 31, 2023
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels May 31, 2023
Signed-off-by: Stewart X Addison <sxa@redhat.com>
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels May 31, 2023
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Nov 17, 2023
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Nov 17, 2023
Signed-off-by: Stewart X Addison <sxa@redhat.com>
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Nov 17, 2023
@andrew-m-leonard
Copy link
Contributor

this has been stale for over a year, converting to "draft", if no longer needed please close.

@andrew-m-leonard andrew-m-leonard marked this pull request as draft April 3, 2024 13:50
@sxa
Copy link
Member Author

sxa commented Apr 3, 2024

I do want this in and working, although it may be superceded by the recent changes in #3735 ...

@keithc-ca
Copy link
Contributor

Now that #3735 is in, this should just add aarch64 to the set of supported architectures for CUDA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch Issues that affect or relate to the aarch ARCHITECTURE macos Issues that affect or relate to the MAC OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants