Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reproducible mac sign process #3443

Merged
merged 1 commit into from
Aug 1, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions tooling/repro_common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ function removeSignatures() {
fi

# Remove any extended app attr
xattr -c "${MAC_JDK_ROOT}"
xattr -cr "${MAC_JDK_ROOT}"

FILES=$(find "${MAC_JDK_ROOT}" \( -type f -and -path '*.dylib' -or -path '*/bin/*' -or -path '*/lib/jspawnhelper' -not -path '*/modules_extracted/*' -or -path '*/jpackageapplauncher*' \))
for f in $FILES
Expand Down Expand Up @@ -128,14 +128,12 @@ function tempSign() {
elif [[ "$OS" =~ Darwin* ]]; then
MAC_JDK_ROOT="${JDK_DIR}/../../Contents"
echo "Adding temp Signatures for ${MAC_JDK_ROOT}"
#TODO Generate locally certificate SELF_CERT

FILES=$(find "${MAC_JDK_ROOT}" \( -type f -and -path '*.dylib' -or -path '*/bin/*' -or -path '*/lib/jspawnhelper' -not -path '*/modules_extracted/*' -or -path '*/jpackageapplauncher*' \))
for f in $FILES
do
echo "Signing $f with a local certificate"
echo "Signing $f with ad-hoc signing"
# Sign both with same local Certificate, this adjusts __LINKEDIT vmsize identically
codesign -s "$SELF_CERT" --options runtime -f --timestamp "$f"
codesign -s "-" "$f"
done
fi
}
Expand Down
Loading