Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code to cross compile x64 jdk8 on arm64 mac #3492

Merged
merged 15 commits into from
Oct 10, 2023
Merged

Add code to cross compile x64 jdk8 on arm64 mac #3492

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
75e5816
Add cross compile steps for x64 jdk8 on m1 macs
Haroon-Khel Oct 3, 2023
e78ccb5
syntax error
Haroon-Khel Oct 3, 2023
901db33
syntax error
Haroon-Khel Oct 3, 2023
6659107
resolve linter error
Haroon-Khel Oct 3, 2023
76cff19
add export
Haroon-Khel Oct 3, 2023
30d0f6d
make link to xcode11.7 using - instead of _
Haroon-Khel Oct 3, 2023
06166c4
Update build-farm/platform-specific-configurations/mac.sh
Haroon-Khel Oct 3, 2023
41e62d7
Update build-farm/platform-specific-configurations/mac.sh
Haroon-Khel Oct 3, 2023
27d0d35
debug
Haroon-Khel Oct 4, 2023
55f0905
wrong uname flag
Haroon-Khel Oct 4, 2023
0d7cb88
add MAC_ROSETTA_PREFIX to the echo command
Haroon-Khel Oct 4, 2023
2a72f3f
temp fix for xcode switch so I can run the tests with the build
Haroon-Khel Oct 4, 2023
35426d7
add /opt/homebrew/bin to beginning of PATH jdk8 mac build
Haroon-Khel Oct 6, 2023
f5b633f
add /opt/homebrew/bin to beginning of PATH jdk8 mac build on arm mach…
Haroon-Khel Oct 6, 2023
19ee7ed
remove debug
Haroon-Khel Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ jobs:
run: |
rm -rf /Applications/Xcode.app
ln -s /Applications/Xcode_11.7.app /Applications/Xcode.app
ln -s /Applications/Xcode_11.7.app /Applications/Xcode-11.7.app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit strange - is this because the github actions runners have it in a different place from the default? i.e. with a _ instead of an - and we have stuff hard coded to use the location with a -?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the runner has it in /Applications/Xcode_11.7.app while the build expects it to be in /Applications/Xcode-11.7.app

Copy link
Member

@sxa sxa Oct 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably one of those is the default location and the discrepancy isn't just because we've changed the default (in which case we'd be able to change it)?


- name: Build macOS
run: |
Expand Down
5 changes: 3 additions & 2 deletions build-farm/make-adopt-build-farm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ if [ -z "$ARCHITECTURE" ]; then
if [ "$ARCHITECTURE" = "powerpc" ]; then ARCHITECTURE=ppc64; fi # AIX
if [ "$ARCHITECTURE" = "arm" ]; then ARCHITECTURE=aarch64; fi # mac/aarch64
if [ "$ARCHITECTURE" = "armv7l" ]; then ARCHITECTURE=arm; fi # Linux/arm32
echo ARCHITECTURE not defined - assuming $ARCHITECTURE
echo ARCHITECTURE not defined - assuming "$ARCHITECTURE"
export ARCHITECTURE
fi

Expand Down Expand Up @@ -132,6 +132,7 @@ CONFIGURE_ARGS_FOR_ANY_PLATFORM=""
CONFIGURE_ARGS=${CONFIGURE_ARGS:-""}
BUILD_ARGS=${BUILD_ARGS:-""}
VARIANT_ARG=""
MAC_ROSETTA_PREFIX=""

if [ -z "${JDK_BOOT_VERSION}" ]
then
Expand Down Expand Up @@ -245,4 +246,4 @@ echo "$PLATFORM_SCRIPT_DIR/../makejdk-any-platform.sh --clean-git-repo --jdk-boo
CONFIGURE_ARGS_FOR_ANY_PLATFORM="${CONFIGURE_ARGS_FOR_ANY_PLATFORM//\"/temporary_speech_mark_placeholder}"

# shellcheck disable=SC2086
bash -c "$PLATFORM_SCRIPT_DIR/../makejdk-any-platform.sh --clean-git-repo --jdk-boot-dir ${JDK_BOOT_DIR} --configure-args \"${CONFIGURE_ARGS_FOR_ANY_PLATFORM}\" --target-file-name ${FILENAME} ${TAG_OPTION} ${OPTIONS} ${BUILD_ARGS} ${VARIANT_ARG} ${JAVA_TO_BUILD}"
bash -c "$MAC_ROSETTA_PREFIX $PLATFORM_SCRIPT_DIR/../makejdk-any-platform.sh --clean-git-repo --jdk-boot-dir ${JDK_BOOT_DIR} --configure-args \"${CONFIGURE_ARGS_FOR_ANY_PLATFORM}\" --target-file-name ${FILENAME} ${TAG_OPTION} ${OPTIONS} ${BUILD_ARGS} ${VARIANT_ARG} ${JAVA_TO_BUILD}"
10 changes: 9 additions & 1 deletion build-farm/platform-specific-configurations/mac.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,18 @@ source "$SCRIPT_DIR/../../sbin/common/constants.sh"
export MACOSX_DEPLOYMENT_TARGET=10.9
export BUILD_ARGS="${BUILD_ARGS}"

## JDK8 only: If, at this point in the build, the architecure of the machine is arm64 while the ARCHITECTURE variable
## is x64 then we need to add the cross compilation option --openjdk-target=x86_64-apple-darwin
MACHINEARCHITECURE=$(uname -a)
Haroon-Khel marked this conversation as resolved.
Show resolved Hide resolved

if [ "${JAVA_TO_BUILD}" == "${JDK8_VERSION}" ]
then
XCODE_SWITCH_PATH="/Applications/Xcode.app"
XCODE_SWITCH_PATH="/Applications/Xcode-11.7.app"
export CONFIGURE_ARGS_FOR_ANY_PLATFORM="${CONFIGURE_ARGS_FOR_ANY_PLATFORM} --with-toolchain-type=clang"
if [[ "${MACHINEARCHITECURE}" == "arm64" ]] && [[ "${ARCHITECTURE}" == "x64" ]]; then
Haroon-Khel marked this conversation as resolved.
Show resolved Hide resolved
export CONFIGURE_ARGS_FOR_ANY_PLATFORM="${CONFIGURE_ARGS_FOR_ANY_PLATFORM} --openjdk-target=x86_64-apple-darwin"
export MAC_ROSETTA_PREFIX="arch -x86_64"
fi
if [ "${VARIANT}" == "${BUILD_VARIANT_OPENJ9}" ]; then
export CONFIGURE_ARGS_FOR_ANY_PLATFORM="${CONFIGURE_ARGS_FOR_ANY_PLATFORM} --with-openssl=fetched --enable-openssl-bundling"
export BUILD_ARGS="${BUILD_ARGS} --skip-freetype"
Expand Down
Loading