Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdk8 select Xcode-11.7 only when cross-compiling #3507

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

jdk8 x64 mac won't build on a x64 node as it tries to force Xcode 11.7

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard andrew-m-leonard self-assigned this Oct 20, 2023
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS cross-compile Issues that affect or relate to cross compiled platforms (e.g. RISC-V) labels Oct 20, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@sxa
Copy link
Member

sxa commented Oct 20, 2023

/merge

@github-actions
Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@gdams
Copy link
Member

gdams commented Oct 20, 2023

/approve

@andrew-m-leonard
Copy link
Contributor Author

/approve

@github-actions github-actions bot dismissed their stale review October 20, 2023 10:03

Thank you @gdams and @andrew-m-leonard for your approvals, this pull request is now approved to merge during release.

@andrew-m-leonard andrew-m-leonard merged commit 698313c into adoptium:master Oct 20, 2023
24 checks passed
andrew-m-leonard added a commit to andrew-m-leonard/openjdk-build that referenced this pull request Oct 20, 2023
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
andrew-m-leonard added a commit that referenced this pull request Oct 20, 2023
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-compile Issues that affect or relate to cross compiled platforms (e.g. RISC-V) macos Issues that affect or relate to the MAC OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants