Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add download and sbom verification scripts #3516

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

sxa
Copy link
Member

@sxa sxa commented Oct 27, 2023

Provides basic IVT testing (Download from the github repos) and validation of GPG and sha checksums as well as some validation of the downloaded SBOM to ensure it meets the CycloneDX requirements and has sane data in it as required to achieve SLSA Level 3 compliance.

This will be run via the jenkins job at https://ci.adoptium.net/job/build-scripts/job/release/job/download_and_sbom_validation - currently restricted access as per other tools in the release folder in jenkins.
Fixes #3506 (that issue has some follow-on ideas for improvements too)
Also probably implements all of the initial reuqirements of #3484 but there will likely be some additions to check the formal mac/windows signing so I don't want that one closed just yet :-)

Note this is not currently added as a formal step into RELEASING.md but that should be included in the future.

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa sxa self-assigned this Oct 27, 2023
@github-actions github-actions bot added jenkins Issues that enhance or fix our jenkins server macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS labels Oct 27, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some shellcheck changes required.

@github-actions github-actions bot added jenkins Issues that enhance or fix our jenkins server macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS and removed macos Issues that affect or relate to the MAC OS jenkins Issues that enhance or fix our jenkins server windows Issues that affect or relate to the WINDOWS OS testing Issues that enhance or fix our test suites labels Oct 31, 2023
@sxa
Copy link
Member Author

sxa commented Oct 31, 2023

/thaw

@github-actions github-actions bot dismissed their stale review October 31, 2023 16:40

Pull Request unblocked - code freeze is over.

@github-actions github-actions bot added jenkins Issues that enhance or fix our jenkins server macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS and removed macos Issues that affect or relate to the MAC OS jenkins Issues that enhance or fix our jenkins server windows Issues that affect or relate to the WINDOWS OS testing Issues that enhance or fix our test suites labels Oct 31, 2023
@github-actions github-actions bot added jenkins Issues that enhance or fix our jenkins server macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS and removed macos Issues that affect or relate to the MAC OS jenkins Issues that enhance or fix our jenkins server windows Issues that affect or relate to the WINDOWS OS testing Issues that enhance or fix our test suites labels Oct 31, 2023
@github-actions github-actions bot added jenkins Issues that enhance or fix our jenkins server macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS and removed macos Issues that affect or relate to the MAC OS jenkins Issues that enhance or fix our jenkins server windows Issues that affect or relate to the WINDOWS OS testing Issues that enhance or fix our test suites labels Oct 31, 2023
Signed-off-by: Stewart X Addison <sxa@redhat.com>
@github-actions github-actions bot added jenkins Issues that enhance or fix our jenkins server macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS and removed macos Issues that affect or relate to the MAC OS jenkins Issues that enhance or fix our jenkins server windows Issues that affect or relate to the WINDOWS OS testing Issues that enhance or fix our test suites labels Oct 31, 2023
@karianna karianna merged commit 2643998 into adoptium:master Nov 1, 2023
23 checks passed
@karianna karianna mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins Issues that enhance or fix our jenkins server macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Provide download test capability
3 participants