-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up release_download_test.sh #3522
Conversation
Thank you for creating a pull request! |
…g in a common script as it is too specific for the validation script.
14df7b9
to
2addfec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - running one final test against jdk-17 then I'll get it merged :-) Thanks for the cleanup!
Hmm the last test I did on jdk-17.0.9+9 failed for the win32 zip files as though the download didn't complete, but it did produce a file of the right size. Trying again ... |
can you provide a link to the jienkins job for inspection? |
It's restricted, so not easily but it looks like it might be reproducible outside jenkins anyway when you run against |
Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
This PR adds support for the following things:
Some things I want to add in a further PR:
@mbarbero @sxa