Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up release_download_test.sh #3522

Merged
merged 19 commits into from
Nov 9, 2023

Conversation

netomi
Copy link
Contributor

@netomi netomi commented Nov 6, 2023

This PR adds support for the following things:

  • support for running the script on machines other than linux-aarch64
  • add support for output coloring if ansi terminal is available
  • add support for additional options to ease testing (e.g. keep workspace instead of downloading all files of a release all the time)
  • adding helper functions for common things like printing errors

Some things I want to add in a further PR:

  • validation of signatures for all files of a mac binary using: https://github.com/indygreg/apple-platform-rs
  • validation of signatures for all files of a windows binary using: https://github.com/mtrojnar/osslsigncode
  • support for all of the included validations for a single binary, e.g. OpenJDK21U-jdk_x64_linux_hotspot_21.0.1_12.tar.gz
  • so that consumers of temurin can validate if the binary they want to use passes all validation and they dont have to validate all binaries of a release which is quite a lot

@mbarbero @sxa

Copy link

github-actions bot commented Nov 6, 2023

Thank you for creating a pull request!
If you have not done so already, please familiarise yourself with our Contributing Guidelines and FAQ, even if you have contributed to the Adoptium project before. GitHub actions will now run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

@github-actions github-actions bot added aarch Issues that affect or relate to the aarch ARCHITECTURE macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS and removed macos Issues that affect or relate to the MAC OS windows Issues that affect or relate to the WINDOWS OS testing Issues that enhance or fix our test suites labels Nov 6, 2023
@netomi netomi force-pushed the improve-release-download-script branch from 14df7b9 to 2addfec Compare November 9, 2023 15:27
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS and removed macos Issues that affect or relate to the MAC OS windows Issues that affect or relate to the WINDOWS OS testing Issues that enhance or fix our test suites labels Nov 9, 2023
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - running one final test against jdk-17 then I'll get it merged :-) Thanks for the cleanup!

@sxa
Copy link
Member

sxa commented Nov 9, 2023

Hmm the last test I did on jdk-17.0.9+9 failed for the win32 zip files as though the download didn't complete, but it did produce a file of the right size. Trying again ...

@netomi
Copy link
Contributor Author

netomi commented Nov 9, 2023

can you provide a link to the jienkins job for inspection?

@sxa
Copy link
Member

sxa commented Nov 9, 2023

can you provide a link to the jienkins job for inspection?

It's restricted, so not easily but it looks like it might be reproducible outside jenkins anyway when you run against jdk-17.0.9+9 - trying to run a few further tests now

tooling/release_download_test.sh Outdated Show resolved Hide resolved
Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS and removed macos Issues that affect or relate to the MAC OS windows Issues that affect or relate to the WINDOWS OS testing Issues that enhance or fix our test suites labels Nov 9, 2023
@sxa sxa merged commit 88779a3 into adoptium:master Nov 9, 2023
23 checks passed
@karianna karianna mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch Issues that affect or relate to the aarch ARCHITECTURE macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants