Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin JDK11 x64 build to XCode rather than commandline tools #3541

Merged
merged 2 commits into from
Nov 21, 2023
Merged

pin JDK11 x64 build to XCode rather than commandline tools #3541

merged 2 commits into from
Nov 21, 2023

Conversation

gdams
Copy link
Member

@gdams gdams commented Nov 21, 2023

Switching JDK11 to a pinned Xcode version rather than command line tools for consistency

@github-actions github-actions bot added the macos Issues that affect or relate to the MAC OS label Nov 21, 2023
@github-actions GitHub Actions
Copy link

Thank you for creating a pull request!
If you have not done so already, please familiarise yourself with our Contributing Guidelines and FAQ, even if you have contributed to the Adoptium project before. GitHub actions will now run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

andrew-m-leonard
andrew-m-leonard approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gdams gdams merged commit 32021ac into adoptium:master Nov 21, 2023
17 of 23 checks passed
@gdams gdams deleted the mac branch November 21, 2023 10:55
@karianna karianna mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

@sxa sxa sxa approved these changes

Assignees
No one assigned
Labels
macos Issues that affect or relate to the MAC OS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdams @sxa @andrew-m-leonard