Document missing disable-adopt-branch-safety #4019
Conversation
makejdk-any-platform.1
Outdated
| @@ -106,6 +106,9 @@ It is known issue: https://github.com/adoptium/temurin-build/issues/3862 | |||
| .BR \-\-debug-docker | |||
| debug OpenJDK build script in a docker container. Only valid if \fB-D\fR is selected. | |||
| .TP | |||
| .BR \-\-disable-adopt-branch-safety | |||
| disable the default check for tags/branches in case of \fBtemurin\fR as --build-variant. | |||
There was a problem hiding this comment.
What's the check? More context will help
There was a problem hiding this comment.
Tbh I'm not sure. i think itis checking whether you are in correct repo, in correcy branch with correct tags.I will try to diga bot more
There was a problem hiding this comment.
I'm sure jsut 51/49 but i read it as follows:
- The
temurinvarinat always checks for tags. - In addition for specific tags.
And the second is more important. If it do not found the correct tags, it fails. If the disable-adopt-branch-safety become true, then the check happens, but if no tag is found, it jsut creates a fake one and continue. So most likely my comment with tags/branches should be just tags. Should I rephrase the man page line?
There was a problem hiding this comment.
Yes and the comment that it is checking if you are in the correct tag is good context to add.
There was a problem hiding this comment.
@karianna ok. In that case I have to verify that I understood it correctly. Tahnk you!
There was a problem hiding this comment.
The more precise description is actually not related to "tags" but the detection of the TEMURIN_MARKER_FILE, which is the file README.JAVASE, which is only present in the Adoptium "mirror" : https://github.com/adoptium/jdk21u/blob/dev/README.JAVASE. This check is to ensure Temurin is building from the Adoptium mirror source, and not something else..., hence the use of the word "safety".
The "fake tag" bit is just an additional bit to avoid the missing _adopt tag associated with not using an Adoptium mirror.
There was a problem hiding this comment.
Thanx a lot, updated.
makejdk-any-platform.1
Outdated
| @@ -106,6 +106,9 @@ It is known issue: https://github.com/adoptium/temurin-build/issues/3862 | |||
| .BR \-\-debug-docker | |||
| debug OpenJDK build script in a docker container. Only valid if \fB-D\fR is selected. | |||
| .TP | |||
| .BR \-\-disable-adopt-branch-safety | |||
| disable the default check for tags/branches in case of \fBtemurin\fR as --build-variant. | |||
There was a problem hiding this comment.
Yes and the comment that it is checking if you are in the correct tag is good context to add.
No description provided.