Additional sentences v1 #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icholy
requested changes
Sep 18, 2023
There was a problem hiding this comment.
Hey, sorry for taking so long to look at this. Can you please change the context values to be more informative? For example change "x" to "thruster no". This will make the error message more useful. Also, are you able to provide any links to documentation about these message types? I'm having a hard time finding anything.
|
I'm closing the PR due to inactivity. @ahmedMHasan please feel free to reopen if you address the requested changes. Thanks! |
|
@ahmedMHasan I'd still like these changes merged if you're willing to re-open an updated version of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request to merge the additional sentences : AZT Azimuth Thruster Message and MCP Micropilot Joystick Controller Message