v0.8.1: allow scrolling on long comments

adrienjoly · Aug 12, 2017 · 6bc920a · 6bc920a
1 parent 3047f4e
commit 6bc920a
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "trello-outliner-power-up",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "Comment Editor by AJ: a Trello Power-Up that allows you to edit card comments using an Outliner.",
   "homepage": "https://adrienjoly.com/trello-outliner",
   "main": "server/server.js",

diff --git a/public/css/comment-editor.css b/public/css/comment-editor.css
@@ -1,18 +1,23 @@
 body {
   background: initial;
   padding: 20px;
-  overflow: hidden;
+  box-sizing: border-box;
+  min-height: 100%;
 }
 
 .window-overlay {
   display: block;
+  overflow-y: scroll;
+  position: absolute;
 }
 
 .window {
   display: block;
   width: inherit;
   margin: 0;
   padding-right: 38px;
+  box-sizing: border-box;
+  overflow-y: scroll;
 }
 
 /* buttons */

diff --git a/public/js/comment-editor.js b/public/js/comment-editor.js
@@ -31,7 +31,11 @@ function initEditor(token, commentId, SimpleMDE) {
       }
     }
     $('.js-close-window').click(closeEditor);
-    $('.window-overlay').click(closeEditor);
+    $('.window-overlay').click(function(e){
+      if(e.target === this){ // ignore clicks on child elements
+        closeEditor();
+      }
+    });
     $(document).keyup(function(e) {
       if (e.keyCode == 27) { // escape key maps to keycode `27`
         closeEditor()

diff --git a/views/comment-editor.html b/views/comment-editor.html
@@ -9,8 +9,7 @@
     <link rel="stylesheet" href="/simplemde/dist/simplemde.min.css">
     <link rel="stylesheet" href="/css/comment-editor.css">
   </head>
-  <body>
-    <div class="window-overlay"></div>
+  <body class="window-overlay">
     <div class="window">
       <div class="window-buttons">
         <a class="window-button icon-lg icon-external-link js-new-tab" href="#"></a>