Merge pull request #1421 from thostetler/more-orcid-fixes

Orcid Fixes
adsabs · Mar 29, 2018 · 1219975 · 1219975
2 parents 6202d94 + 47dac4b
commit 1219975
Show file tree

Hide file tree

Showing 8 changed files with 262 additions and 183 deletions.
diff --git a/src/js/mixins/papers_utils.js b/src/js/mixins/papers_utils.js
@@ -137,7 +137,10 @@ define([
       data.details = data.details || {shortAbstract: data.shortAbstract, pub: data.pub, abstract : data.abstract};
       data.num_citations = data["[citations]"] ? data["[citations]"]["num_citations"] : undefined;
       data.identifier = data.bibcode;
-      data.encodedIdentifier = encodeURIComponent(data.identifier);
+
+      // make sure undefined doesn't become "undefined"
+      data.encodedIdentifier = _.isUndefined(data.identifier) ? 
+        data.identifier : encodeURIComponent(data.identifier);
 
       if (data.pubdate || data.shortAbstract){
         data.popover = true;