Merge pull request #1207 from adsabs/fix-bootstrap-500-errors

Fix bootstrap 500 errors
adsabs · Jul 21, 2017 · 1bcb231 · 1bcb231
2 parents 620f8c1 + a6a5ea2
commit 1bcb231
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 14 deletions.
diff --git a/src/404.html b/src/404.html
@@ -7,7 +7,8 @@
         require.config({
             paths: {
                 'google-analytics': '//www.google-analytics.com/analytics',
-                'analytics': 'js/components/analytics'
+                'analytics': 'js/components/analytics',
+                'jquery': '//ajax.googleapis.com/ajax/libs/jquery/2.0.3/jquery.min'
             },
             map: {
                 'analytics': {

diff --git a/src/500.html b/src/500.html
@@ -7,7 +7,8 @@
         require.config({
             paths: {
                 'google-analytics': '//www.google-analytics.com/analytics',
-                'analytics': 'js/components/analytics'
+                'analytics': 'js/components/analytics',
+                'jquery': '//ajax.googleapis.com/ajax/libs/jquery/2.0.3/jquery.min'
             },
             map: {
                 'analytics': {

diff --git a/src/js/apps/discovery/main.js b/src/js/apps/discovery/main.js
@@ -81,7 +81,7 @@ define(['config', 'module'], function(config, module) {
           }
 
         }).fail(function () {
-          app.redirect('/500.html');
+          app.redirect('500.html');
         });
 
       }).fail(function() {
@@ -90,7 +90,7 @@ define(['config', 'module'], function(config, module) {
           return
         }
         // if we failed loading, retry *once again* (and give up eventually)
-        app.reload('/404.html');
+        app.reload('404.html');
       });
 
     });

diff --git a/src/js/mixins/discovery_bootstrap.js b/src/js/mixins/discovery_bootstrap.js
@@ -80,6 +80,7 @@ define([
       // XXX:rca - solve this better, through config
       var beehive = this.getBeeHive();
       var dynConf = this.getObject('DynamicConfig');
+      var timeout = 3000;
 
       var defer = $.Deferred();
 
@@ -103,7 +104,8 @@ define([
             pendingReqs--;
             if (pendingReqs <= 0) defer.resolve(retVal);
           },
-          type: 'GET'
+          type: 'GET',
+          timeout: timeout - 1
         };
         var redirect_uri = location.origin + location.pathname;
 
@@ -125,17 +127,16 @@ define([
         });
 
         setTimeout(function() {
-            if (defer.state() == 'resolved')
-              return;
-            defer.reject();
-          },
-          3000);
+          if (defer.state() === 'resolved') {
+            return;
+          }
+          defer.reject();
+        }, timeout);
       }
       else {
         setTimeout(function() {
-          defer.resolve({}),
-            1
-        });
+          defer.resolve({});
+        }, 1);
       }
       return defer;
     },

diff --git a/src/js/services/api.js b/src/js/services/api.js
@@ -143,9 +143,13 @@ define([
         context: {request: request, api: self },
         timeout: this.defaultTimeoutInMs,
         headers: {},
-        cache: true, // do not generate _ parameters (let browser cache responses),
+        cache: true // do not generate _ parameters (let browser cache responses),
       };
 
+      if (options.timeout) {
+        opts.timeout = options.timeout;
+      }
+
       if (this.clientVersion) {
         opts.headers['X-BB-Api-Client-Version'] = this.clientVersion;
       }