Merge pull request #2021 from thostetler/siteimprove-updates

A11y fixes
adsabs · Mar 31, 2020 · a1c3f27 · a1c3f27
2 parents f77d6fd + 5f661e1
commit a1c3f27
Show file tree

Hide file tree

Showing 97 changed files with 18,144 additions and 20,054 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -49,6 +49,8 @@
     "indent": "off",
     "space-before-blocks": "off",
     "quote-props": "off",
-    "react/jsx-filename-extension": "off"
+    "react/jsx-filename-extension": "off",
+    "no-script-url": "off",
+    "jsx-a11y/anchor-is-valid": "off"
   }
 }
diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
diff --git a/package.json b/package.json
@@ -24,7 +24,7 @@
     "prop-types": "^15.6.0",
     "react": "^16.12.0",
     "react-dom": "^16.12.0",
-    "react-redux": "^7.1.3",
+    "react-redux": "^7.2.0",
     "requirejs": "^2.3.5"
   },
   "devDependencies": {

diff --git a/src/js/apps/discovery/main.js b/src/js/apps/discovery/main.js
@@ -124,8 +124,8 @@ define(['config/discovery.config', 'module'], function(config, module) {
 
             $sidebar.toggleClass('show');
             var text = $sidebar.hasClass('show')
-              ? '  <i class="fa fa-close"></i> Close Menu'
-              : ' <i class="fa fa-bars"></i> Show Menu';
+              ? '  <i class="fa fa-close" aria-hidden="true"></i> Close Menu'
+              : ' <i class="fa fa-bars" aria-hidden="true"></i> Show Menu';
             $button.html(text);
           });
 

diff --git a/src/js/components/query_builder/plugin.js b/src/js/components/query_builder/plugin.js
@@ -858,19 +858,19 @@ define([
       &nbsp;&nbsp;\
     </div> \
     <div class="btn-group"> \
-      <button type="button" class="btn btn-xs btn-success" data-add="rule"><i class="fa fa-plus"></i> ' +
+      <button type="button" class="btn btn-xs btn-success" data-add="rule"><i class="fa fa-plus" aria-hidden="true"></i> ' +
               this.lang.add_rule +
               '</button> \
-      <button type="button" class="btn btn-xs btn-success" data-add="group"><i class="fa fa-plus-square"></i> ' +
+      <button type="button" class="btn btn-xs btn-success" data-add="group"><i class="fa fa-plus-square" aria-hidden="true"></i> ' +
               this.lang.add_group +
               '</button> \
-      <button type="button" class="btn btn-xs btn-danger" data-delete="group"><i class="fa fa-minus"></i> ' +
+      <button type="button" class="btn btn-xs btn-danger" data-delete="group"><i class="fa fa-minus" aria-hidden="true"></i> ' +
               this.lang.delete_group +
               '</button> \
     </div> \
     ' +
               (this.settings.sortable
-                ? '<div class="drag-handle"><i class="fa fa-sort"></i></div>'
+                ? '<div class="drag-handle"><i class="fa fa-sort" aria-hidden="true"></i></div>'
                 : '') +
               ' \
   </dt> \