Automatic room upgrade handling can be used maliciously to bridge a room non-consentually
Moderate severity
GitHub Reviewed
Published
Jun 16, 2021
in
matrix-org/matrix-appservice-bridge
•
Updated Feb 1, 2023
Description
Published by the National Vulnerability Database
Jun 16, 2021
Reviewed
Jun 16, 2021
Published to the GitHub Advisory Database
Jun 21, 2021
Last updated
Feb 1, 2023
Impact
If a bridge has room upgrade handling turned on in the configuration (the
roomUpgradeOpts
key when instantiating a newBridge
instance.), anym.room.tombstone
event it encounters will be used to unbridge the current room and bridge into the target room. However, the target roomm.room.create
event is not checked to verify if thepredecessor
field contains the previous room. This means that any mailcious admin of a bridged room can repoint the traffic to a different room without the new room being aware.Patches
Versions 2.6.1 and greater are patched.
Workarounds
Disabling the automatic room upgrade handling can be done by removing the
roomUpgradeOpts
key from theBridge
class options.References
The issue is patched by matrix-org/matrix-appservice-bridge#330
For more information]
If you have any questions or comments about this advisory, email us at security@matrix.org.
References