Skip to content

incorrect order of evaluation of side effects for some builtins

Moderate severity GitHub Reviewed Published Sep 2, 2023 in vyperlang/vyper • Updated Nov 7, 2023

Package

pip vyper (pip)

Affected versions

<= 0.3.9

Patched versions

0.3.10

Description

Impact

The order of evaluation of the arguments of the builtin functions uint256_addmod, uint256_mulmod, ecadd and ecmul does not follow source order.
• For uint256_addmod(a,b,c) and uint256_mulmod(a,b,c), the order is c,a,b.
• For ecadd(a,b) and ecmul(a,b), the order is b,a.

Note that this behaviour is problematic when the evaluation of one of the arguments produces side effects that other arguments depend on.

Patches

vyperlang/vyper#3583

Workarounds

When using builtins from the list above, make sure that the arguments of the expression do not produce side effects or, if one does, that no other argument is dependent on those side effects.

References

Are there any links users can visit to find out more?

References

@charles-cooper charles-cooper published to vyperlang/vyper Sep 2, 2023
Published to the GitHub Advisory Database Sep 4, 2023
Reviewed Sep 4, 2023
Published by the National Vulnerability Database Sep 4, 2023
Last updated Nov 7, 2023

Severity

Moderate

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
None
Integrity
Low
Availability
None

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N

EPSS score

0.053%
(22nd percentile)

Weaknesses

CVE ID

CVE-2023-41052

GHSA ID

GHSA-4hg4-9mf5-wxxq

Source code

Credits

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.