Utils.readChallengeTx does not verify the server account signature
Moderate severity
GitHub Reviewed
Published
Jul 2, 2021
in
stellar/js-stellar-sdk
•
Updated Jan 27, 2023
Description
Reviewed
Jul 2, 2021
Published by the National Vulnerability Database
Jul 2, 2021
Published to the GitHub Advisory Database
Jul 2, 2021
Last updated
Jan 27, 2023
The
Utils.readChallengeTx
function used in SEP-10 Stellar Web Authentication states in its function documentation that it reads and validates the challenge transaction including verifying that theserverAccountID
has signed the transaction. The function does not verify that the server has signed the transaction and has been fixed so that it does in v8.2.3.Applications that also used
Utils.verifyChallengeTxThreshold
orUtils.verifyChallengeTxSigners
to verify the signatures including the server signature on the challenge transaction are unaffected as those functions verify the server signed the transaction.Applications calling
Utils.readChallengeTx
should update to v8.2.3 to ensure that the challenge transaction is completely valid and signed by the server creating the challenge transaction.References