Integer truncation in Shard API usage
High severity
GitHub Reviewed
Published
Sep 24, 2020
in
tensorflow/tensorflow
•
Updated Oct 28, 2024
Package
Affected versions
< 1.15.4
>= 2.0.0, < 2.0.3
>= 2.1.0, < 2.1.2
= 2.2.0
= 2.3.0
Patched versions
1.15.4
2.0.3
2.1.2
2.2.1
2.3.1
< 1.15.4
>= 2.0.0, < 2.0.3
>= 2.1.0, < 2.1.2
= 2.2.0
= 2.3.0
1.15.4
2.0.3
2.1.2
2.2.1
2.3.1
< 1.15.4
>= 2.0.0, < 2.0.3
>= 2.1.0, < 2.1.2
= 2.2.0
= 2.3.0
1.15.4
2.0.3
2.1.2
2.2.1
2.3.1
Description
Reviewed
Sep 25, 2020
Published to the GitHub Advisory Database
Sep 25, 2020
Published by the National Vulnerability Database
Sep 25, 2020
Last updated
Oct 28, 2024
Impact
The
Shard
API in TensorFlow expects the last argument to be a function taking twoint64
(i.e.,long long
) arguments:https://github.com/tensorflow/tensorflow/blob/0e68f4d3295eb0281a517c3662f6698992b7b2cf/tensorflow/core/util/work_sharder.h#L59-L60
However, there are several places in TensorFlow where a lambda taking
int
orint32
arguments is being used:https://github.com/tensorflow/tensorflow/blob/0e68f4d3295eb0281a517c3662f6698992b7b2cf/tensorflow/core/kernels/random_op.cc#L204-L205
https://github.com/tensorflow/tensorflow/blob/0e68f4d3295eb0281a517c3662f6698992b7b2cf/tensorflow/core/kernels/random_op.cc#L317-L318
In these cases, if the amount of work to be parallelized is large enough, integer truncation occurs. Depending on how the two arguments of the lambda are used, this can result in segfaults, read/write outside of heap allocated arrays, stack overflows, or data corruption.
Patches
We have patched the issue in 27b417360cbd671ef55915e4bb6bb06af8b8a832 and ca8c013b5e97b1373b3bb1c97ea655e69f31a575. We will release patch releases for all versions between 1.15 and 2.3.
We recommend users to upgrade to TensorFlow 1.15.4, 2.0.3, 2.1.2, 2.2.1, or 2.3.1.
For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.
Attribution
This vulnerability has been reported by members of the Aivul Team from Qihoo 360.
References