Heap buffer overflow due to incorrect hash function in TensorFlow
Moderate severity
GitHub Reviewed
Published
May 17, 2022
in
tensorflow/tensorflow
•
Updated Jun 30, 2023
Description
Published by the National Vulnerability Database
May 21, 2022
Published to the GitHub Advisory Database
May 24, 2022
Reviewed
May 24, 2022
Last updated
Jun 30, 2023
Impact
The
TensorKey
hash function used total estimatedAllocatedBytes()
, which (a) is an estimate per tensor, and (b) is a very poor hash function for constants (e.g.int32_t
). It also tried to access individual tensor bytes throughtensor.data()
of sizeAllocatedBytes()
. This led to ASAN failures because theAllocatedBytes()
is an estimate of total bytes allocated by a tensor, including any pointed-to constructs (e.g. strings), and does not refer to contiguous bytes in the.data()
buffer. We couldn't use this byte vector anyways, since types liketstring
include pointers, whereas we need to hash the string values themselves.Patches
We have patched the issue in GitHub commit 1b85a28d395dc91f4d22b5f9e1e9a22e92ccecd6.
The fix will be included in TensorFlow 2.9.0. We will also cherrypick this commit on TensorFlow 2.8.1, which is the only other affected version.
For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.
References