Skip to content

Commit

Permalink
Should save actions by only pushing to docker if tests pass. Might ma…
Browse files Browse the repository at this point in the history
…ke another for development only?
  • Loading branch information
AndrewQuijano committed Nov 1, 2023
1 parent 6e6c0ba commit b6e22c2
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 51 deletions.
32 changes: 31 additions & 1 deletion .github/workflows/build-gradle-project.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Build Gradle project

on:
push:
branches:
- main

jobs:
build-gradle-project:
Expand Down Expand Up @@ -35,4 +37,32 @@ jobs:
- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
token: ${{ secrets.CODECOV_TOKEN }}

# This workflow uses actions that are not certified by GitHub.
# They are provided by a third-party and are governed by
# separate terms of service, privacy policy, and support
# documentation.

# GitHub recommends pinning actions to a commit SHA.
# To get a newer version, you will need to update the SHA.
# You can also reference a tag or branch, but the action may change without warning.

# https://github.com/docker/build-push-action

- name: Login to Docker Hub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2

- name: Build and push
uses: docker/build-push-action@v4
with:
context: .
file: ./Dockerfile
push: true
tags: ${{ secrets.DOCKERHUB_USERNAME }}/ppdt:latest
49 changes: 0 additions & 49 deletions .github/workflows/build-push-action.yml

This file was deleted.

2 changes: 1 addition & 1 deletion create_keystore.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ keytool -genkey -noprompt \
# -Djavax.net.ssl.keyStore=${KEYSTORE} -Djavax.net.ssl.keyStorePassword=${PASSWORD}
# -Djavax.net.ssl.trustStore=${KEYSTORE} -Djavax.net.ssl.trustStorePassword=${PASSWORD}

# keytool -export -alias "${ALIAS}" -keystore "${KEYSTORE}" -rfc -file "${CERTIFICATE}" -storepass "${PASSWORD}"
keytool -export -alias "${ALIAS}" -keystore "${KEYSTORE}" -rfc -file "${CERTIFICATE}" -storepass "${PASSWORD}"

0 comments on commit b6e22c2

Please sign in to comment.