This repository has been archived by the owner on Aug 8, 2022. It is now read-only.
Allow binding to multiple routing keys #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcazevedo
suggested changes
Dec 20, 2018
| @@ -75,7 +75,7 @@ object Amqp { | |||
| */ | |||
| case class ChannelParameters(qos: Int, global: Boolean = false) | |||
|
|
|||
| case class Binding(exchange: ExchangeParameters, queue: QueueParameters, routingKey: String) | |||
| case class Binding(exchange: ExchangeParameters, queue: QueueParameters, routingKeys: Set[String]) | |||
There was a problem hiding this comment.
I think it's preferable to use varargs instead of a Set here, as it will make the declaration of Bindings simpler. The same applies to QueueBind below.
There was a problem hiding this comment.
The approach discussed offline (re-ordering arguments) won't work because of the default argument value in:
case class QueueBind(queue: String, exchange: String, routingKeys: Set[String], args: Map[String, AnyRef] = Map.empty) extends Request
This:
case class QueueBind(queue: String, exchange: String, args: Map[String, AnyRef] = Map.empty, routingKeys: String*) extends Request
is not allowed.
I'm thinking it might be best to leave this as is. Any ideas?
Co-Authored-By: belerophon <thyandrecardoso@hotmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow bindings to multiple routing keys, tackling sstone#68 and further working on sstone#73.