hail dependency issue #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristinaXu2017
changed the title
ChristinaXu2017
changed the title
|
Looks good, and we'll be dropping all hail dependencies soon enough, so this is very unlikely to come back to bite us. |
bhosking
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problems are addressed in issue #239
This repo removes the broken dependency hail_2.12_3.1-0.2.74-SNAPSHOT-all.jar from pom.xml. This dependency was only required during unit test won't affect our runtime execution. The existing dependency hail_2.12_3.1-0.2.74-SNAPSHOT.jar also works well during unit tests. Hence, we remove this redundant and broken one from dependency lists.