Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of basic controller logic #21

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

sircthulhu
Copy link
Member

@sircthulhu sircthulhu commented Mar 14, 2024

Controller now can successfully bootstrap etcd cluster :)

Controller creates Service, ConfigMap and StatefulSet based on EtcdCluster CR
Only EmptyDir storage is supported
Initialized status is being set and updated

fixes #13

- sts, svc and cm are created by operator
- "Initialized" status is being set and updated
- etcd cluster successfully bootstraps
Comment on lines 73 to 74
image: controller:latest
imagePullPolicy: Never
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest use full image path ghcr.io/aenix-io/controller:latest and imagePullPolicy: IfNotPresent for reuse yaml in static manifests and helm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be ghcr.io/aenix-io/etcd-operator/controller:latest or ghcr.io/aenix-io/etcd-operator:latest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or ghcr.io/aenix-io/etcd-operator/etcd-operator:latest

@hiddenmarten could you comment on this, please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kvaps
Sure, I think it's better to use a simple structure of image tag, that will correspond with a GitHub repo path (It helps to avoid confusion):
{registry}/{organisation}/{application}:{versionBySemVer}

So, as a result:
ghcr.io/aenix-io/etcd-operator:v0.0.0

@sircthulhu sircthulhu enabled auto-merge (squash) March 15, 2024 06:07
api/v1alpha1/etcdcluster_types.go Outdated Show resolved Hide resolved
internal/controller/etcdcluster_controller.go Outdated Show resolved Hide resolved
internal/controller/etcdcluster_controller.go Outdated Show resolved Hide resolved
internal/controller/etcdcluster_controller.go Outdated Show resolved Hide resolved
@sircthulhu sircthulhu merged commit 315849f into main Mar 15, 2024
1 of 2 checks passed
@sircthulhu sircthulhu deleted the 13-impl-basic-controller-logic branch March 15, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write basic etcd-operator logic
6 participants