-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of basic controller logic #21
Conversation
- sts, svc and cm are created by operator - "Initialized" status is being set and updated - etcd cluster successfully bootstraps
config/manager/manager.yaml
Outdated
image: controller:latest | ||
imagePullPolicy: Never |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest use full image path ghcr.io/aenix-io/controller:latest
and imagePullPolicy: IfNotPresent
for reuse yaml in static manifests and helm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be ghcr.io/aenix-io/etcd-operator/controller:latest
or ghcr.io/aenix-io/etcd-operator:latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or ghcr.io/aenix-io/etcd-operator/etcd-operator:latest
@hiddenmarten could you comment on this, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kvaps
Sure, I think it's better to use a simple structure of image tag, that will correspond with a GitHub repo path (It helps to avoid confusion):
{registry}/{organisation}/{application}:{versionBySemVer}
So, as a result:
ghcr.io/aenix-io/etcd-operator:v0.0.0
Controller now can successfully bootstrap etcd cluster :)
Controller creates Service, ConfigMap and StatefulSet based on EtcdCluster CR
Only EmptyDir storage is supported
Initialized status is being set and updated
fixes #13