Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker related scripts #37

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

BertScholten
Copy link
Member

Docker stuff more consistent with register/calculator. This should make it possible to use the same way those products work, where docker compose is run in a container, and we can actually use version 3.8.

Docker stuff more consistent with register/calculator. This should make it possible to use the same way those products work, where docker compose is run in a container, and we can actually use version 3.8.
@BertScholten BertScholten requested a review from SerhatG December 20, 2023 11:04
docker/nl/.env Outdated Show resolved Hide resolved
Some copy+paste errors, also changed image names defined in the docker-compose.yaml.
@BertScholten BertScholten requested a review from SerhatG December 20, 2023 11:49
Copy link
Member

@SerhatG SerhatG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One improvement, LGTM otherwise.

Co-authored-by: Serhat <SerhatG@users.noreply.github.com>
@BertScholten BertScholten merged commit 7ac3e6d into aerius:main Dec 20, 2023
1 check passed
@BertScholten BertScholten deleted the AER-2570_fix_docker_compose_3 branch December 20, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants