-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker related scripts #37
Merged
BertScholten
merged 3 commits into
aerius:main
from
BertScholten:AER-2570_fix_docker_compose_3
Dec 20, 2023
Merged
Docker related scripts #37
BertScholten
merged 3 commits into
aerius:main
from
BertScholten:AER-2570_fix_docker_compose_3
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker stuff more consistent with register/calculator. This should make it possible to use the same way those products work, where docker compose is run in a container, and we can actually use version 3.8.
SerhatG
reviewed
Dec 20, 2023
SerhatG
reviewed
Dec 20, 2023
SerhatG
reviewed
Dec 20, 2023
SerhatG
reviewed
Dec 20, 2023
SerhatG
reviewed
Dec 20, 2023
Some copy+paste errors, also changed image names defined in the docker-compose.yaml.
SerhatG
reviewed
Dec 20, 2023
SerhatG
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One improvement, LGTM otherwise.
Co-authored-by: Serhat <SerhatG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker stuff more consistent with register/calculator. This should make it possible to use the same way those products work, where docker compose is run in a container, and we can actually use version 3.8.