WIP Update Bevy to main #19
Draft
+95
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
commented
Sep 24, 2024
Comment on lines
+93
to
+94
| let target_dist = (editor_cam.orthographic.scale_to_near_clip | ||
| * (orthographic.area.width() * orthographic.area.height())) |
There was a problem hiding this comment.
This is definitely wrong, but I'm not sure what to put there.
There was a problem hiding this comment.
I think scale has been replaced with setting it here: https://dev-docs.bevyengine.org/bevy/render/camera/enum.ScalingMode.html
There was a problem hiding this comment.
It defaults to ScalingMode::WindowSize(1.0), and now if you were using scale of 2.0, you would now do ScalingMode::WindowSize(2.0). You will need to match on the scaling enum and extract the multiplier. I'm not sure if we can support anything other than windowsize, or if there is a better way to do this.
Vrixyz
commented
Sep 24, 2024
|
|
||
| ortho.scale = (*triangle_base * multiplier) as f32; | ||
| let normalized_projection = ortho.scaling_mode / multiplier as f32; | ||
| ortho.scaling_mode = normalized_projection * *triangle_base as f32; |
There was a problem hiding this comment.
modifications in this file are also difficult to assess for me. They are definitely wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently testing on bevy commit 9386bd0
Notable changes from bevy:
Msaato component bevyengine/bevy#14273