-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support oculus touch #164
Support oculus touch #164
Conversation
should have same as prior functionality with Vive (where first controller is right hand and second controller is left) |
ef37b75
to
d7714a6
Compare
@fernandojsg happily this appears to work with both latest 0.3.2 you have in master and also #163 |
d7714a6
to
5aeaf2b
Compare
@fernandojsg thanks for merging #163 -- rebuilt this on top, so you should be able to merge directly |
@fernandojsg in thinking about it, the presence of the build.js file might get in the way of merge if you're going to rebuild, let me know if you'd like me to remove that file from the changeset |
touch controllers are readily identifiable with tojiro's chromium but not sure if so w.r.t. openvr in nightly... should we make them work at all in chromium first, and see how much complaint there is out there before customizing? biggest (only?) functional issue is thumbstick recentering making it hard to select brush size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could just make vive-controls
, oculus-touch-controls
dependencies of painter-controls
. We would also have to wire the touch buttons to the apainter actions like the undo or the brush size selector
so if we let the model come from
IMO,
|
Regarding thmbstick: Touchpad gesture for brush size should be relative #180 |
before #2132 is merged into aframevr/aframe, by auto-detecting which type of controller is present don't inject auto-detect-controllers until we know which hand; ignore absent buttonMeshes updated build file after rebase with aframe master
5aeaf2b
to
f8ee5f8
Compare
Closed by #194 |
per discussion on #159; works with #163