Closes #309: Ensures we compile pattern variables correctly #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespercockx
approved these changes
Jun 9, 2024
|
The test suite fails on the following: Since our test infrastructure is pretty basic (see #153), you need to explicitly add |
VictorCMiraldo
force-pushed
the
vcm/closes-309
branch
from
feb3b23 to
2a1fb52
Compare
|
@jespercockx I just added it to the |
|
You can run |
…lying on the existing compileTypeArgs.
VictorCMiraldo
force-pushed
the
vcm/closes-309
branch
from
2a1fb52 to
ae26a46
Compare
|
Cool! I think I finally got it! 🤞 |
|
Perfect, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
compileTypeArgsin this module was failing to update the context on recursive calls, causing the De Bruijn indices to get messed up. This PR relies on the existingcompileTypeArgsinstead. Closes #309