Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: change prop-types from peerDep to plain dep #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lbfrancisco
Copy link

prop-types aren't installed automatically when react-signature-canvas was installed.

image

prop-types aren't installed automatically when react-signature-canvas was installed.
@agilgur5 agilgur5 changed the title update: change prop-types from peerDependencies to dependencies deps: change prop-types from peerDep to plain dep Nov 3, 2023
@agilgur5
Copy link
Owner

agilgur5 commented Nov 3, 2023

prop-types has been a peerDep practically since it was spun out of React 6 years ago: #3.
So I'm not sure we should really change that without solid reason. Haven't heard a user complaint about it in those 6 years, even despite the ecosystem has changed how it handles peerDeps a few times now.

prop-types aren't installed automatically when react-signature-canvas was installed.

For instance, this behavior depends quite heavily on your package manager, and is not a bug of react-signature-canvas. If your package manager doesn't install peerDeps automatically, that is correct behavior.

It appears that the React team officially recommended it to be a dep shortly after its release though (facebook/prop-types#44), so it could be moved, but I'd still think it be good to not have duplicate prop-types packages in a user's tree

@agilgur5 agilgur5 added the scope: dependencies Pull requests that update a dependency file label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants