Fix apparmor profile for usage with enabled NotificationCommand #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow rw for /dev/null, which is used as STDIN/OUT/ERR for the configured NotificationCommand. Add include for local apparmor override file, where rules for the notification command binary can be added by the local administrator without touching the included profile for xmpp-client itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Remarks:
The local include could also point to a more default location (for most distros, this would probably be
<local/usr.bin.xmpp-client>), but since the included apparmor profile is not namedusr.bin.xmpp-clientat the moment, this might be left to downstream distributors.If desired, I could write a paragraph for the README describing how to setup the apparmor profile with enabled NotificationCommand. I tested the updated profile with a custom local override file for my NotificationCommand using debian sid and did not experience any problems.