Skip to content

Commit

Permalink
chore: review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
jacobdadams committed May 31, 2024
1 parent e972711 commit 92c1e03
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/wmrc/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def _build_field_mapping(self):

#: Get a dataframe of the first 200 rows with all the columns so we can extract the needed columns
df_for_columns = self.salesforce_extractor.get_records(
"services/data/v60.0/query/", "SELECT FIELDS(ALL) from Application_Report__c LIMIT 200"
"services/data/v60.0/query/", "SELECT FIELDS(ALL) from Application_Report__c LIMIT 1"
)
self.county_fields = [col for col in df_for_columns.columns if "_County" in col]
self.county_fields.append("Out_of_State__c")
Expand Down
9 changes: 2 additions & 7 deletions src/wmrc/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,6 @@ def _get_secrets():
def _initialize_supervisor(self):
"""A helper method to set up logging and supervisor
Args:
log_path (Path): File path for the logfile to be written
sendgrid_api_key (str): The API key for sendgrid for this particular application
Returns:
Supervisor: The supervisor object used for sending messages
"""
Expand Down Expand Up @@ -117,12 +113,11 @@ def _initialize_supervisor(self):
)
)

def _remove_log_file_handlers(self, loggers):
def _remove_log_file_handlers(self, loggers: list[str]):
"""A helper function to remove the file handlers so the tempdir will close correctly
Args:
log_name (str): The logfiles filename
loggers (List<str>): The loggers that are writing to log_name
loggers (list[str]): The loggers that are writing to log_name
"""

for logger in loggers:
Expand Down

0 comments on commit 92c1e03

Please sign in to comment.