Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation scripts #51

Merged
merged 21 commits into from
Aug 12, 2024
Merged

Validation scripts #51

merged 21 commits into from
Aug 12, 2024

Conversation

jacobdadams
Copy link
Member

This PR focuses on a validation script that generates a csv comparing changes year-over year for several metrics by facility, county, and statewide. This will be run manually and locally as needed, usually in spring as reports for the previous year are submitted.

The output will allow WMRC staff to identify large discrepancies year to year that might indicate typos or other situations that could make it difficult accurately identify long-term trends.

Tucked in the middle of this is a change to a live field name that got it's name truncated in length by AGOL during a manual update to add a new facility type.

steveoh
steveoh previously approved these changes Aug 8, 2024
Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

src/wmrc/main.py Show resolved Hide resolved
src/wmrc/validate.py Outdated Show resolved Hide resolved
src/wmrc/validate.py Outdated Show resolved Hide resolved
stdavis
stdavis previously approved these changes Aug 8, 2024
Copy link
Member

@stdavis stdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have anything else to add. Looks good to me!

@jacobdadams
Copy link
Member Author

Ok, I've updated it to include a separate schedule for the validation logic (which entailed updating the triggering function as per gen2 Cloud Function instructions). The check year is set automatically, and the validation sheet is emailed using Supervisor.

steveoh
steveoh previously approved these changes Aug 12, 2024
Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

src/wmrc/config.py Outdated Show resolved Hide resolved
@jacobdadams jacobdadams merged commit 4713158 into main Aug 12, 2024
7 checks passed
@jacobdadams jacobdadams deleted the dev branch August 16, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants