-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowed wait_socket_readable/writable to accept a file descriptor #824
Conversation
06b8c7a
to
dba7f1b
Compare
0c94b30
to
e2fd980
Compare
Not sure about the mypy error:
|
d5405fc
to
03a0c6b
Compare
You really should install |
The docs build is now failing due to the typeshed annotation. I don't remember off hand how I've dealt with this previously. |
I'm not sure why docs fails. |
Ah, I remember now. Check out |
b9207d0
to
f47cec6
Compare
82f4f6c
to
e60655c
Compare
e60655c
to
4b61ff8
Compare
4a2ff20
to
047791d
Compare
Please stop force pushing your changes. It makes the review process much harder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the proper Sphinx annotation for deprecations.
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
One more thing: the new functions need to be added to the API documentation too. |
For the time being, only issues are linked from the changelog.
for more information, see https://pre-commit.ci
Changes
Fixes #821.
It seems that
anyio.wait_socket_readable(sock)
andanyio.wait_socket_writable(sock)
can not only accept asocket.socket
but also the socket's file descriptor (int
):.fileno()
method returning a file descriptor.Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/
) added which would fail without your patchdocs/
, in case of behavior changes or newfeatures)
docs/versionhistory.rst
).