Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CronTrigger deserialization for JSONSerializer #824

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

tdzienniak
Copy link
Contributor

I noticed that the field _last_fire_time in CronTrigger is not properly deserialized when JSONSerializer is used, which causes the following error:
image

I added a converter to ensure this field is always a valid datetime.

@coveralls
Copy link

coveralls commented Dec 1, 2023

Coverage Status

coverage: 91.677%. remained the same
when pulling 1fc75f6 on Optibus:master
into 3a8977c on agronholm:master.

@agronholm agronholm merged commit 6b816c1 into agronholm:master Dec 2, 2023
13 checks passed
@agronholm
Copy link
Owner

Thanks, good catch! Now I have to fix the same issue in IntervalTrigger and CalendarIntervalTrigger too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants