Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy store should remove finished schedules on cleanup #889

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

Reskov
Copy link
Contributor

@Reskov Reskov commented Apr 8, 2024

It looks like a typo error because a similar code in the mongodb/memory module deletes finished schedules.

I have modified a test case for two reasons:

  1. it was not executed on all data stores
  2. the anyio.Event() is not serializable across different datastores, resulting in an error before execution.

@Reskov Reskov force-pushed the asyncpg-cleanup-fix branch from a0ae8c4 to a998e83 Compare April 8, 2024 16:47
@coveralls
Copy link

coveralls commented Apr 8, 2024

Coverage Status

coverage: 92.596% (+0.04%) from 92.561%
when pulling c941712 on Reskov:asyncpg-cleanup-fix
into 65b7606 on agronholm:master.

@agronholm
Copy link
Owner

Looks good at a glance. I'll give it a proper review within a couple days.

@agronholm agronholm merged commit 3e42a1b into agronholm:master Apr 17, 2024
13 checks passed
@agronholm
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants