-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the test dependencies install psycopg with extra binary #992
Conversation
Why? |
Before, when installing the requirements with just the command: And then running the tests, all tests related to psycopg were skipped saying that psycopg was not installed. |
Maybe this didn't happen to you because you already had the requirements installed on your system before installing psycopg. |
Then why is it not happening in the CI either? https://github.com/agronholm/apscheduler/actions/runs/11903322842/job/33170050358 |
These CI systems probably already come with several requirements installed. (Docker type that is already installed) |
The log output does not support that supposition:
|
Could this be an artifact of missing |
Reading the installation docs, it seems clear that |
This is what I get when trying to import
|
Exactly that, the lack of this requirement in the system caused pytest to skip the tests related to psycopg, claiming that it was not installed. Therefore, adding the extra binary solves these operating system requirement problems. |
Changes
Fixes #.
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/
) added which would fail without your patchdocs/
, in case of behavior changes or newfeatures)
docs/versionhistory.rst
).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**
as the version.If, say, your patch fixes issue #999, the entry should look like this:
* Fix big bad boo-boo in the async scheduler (#999 <https://github.com/agronholm/apscheduler/issues/999>_; PR by @yourgithubaccount)
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.