[Feature] Migrate to urfave/cli/v2 #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR investigates upgrading to v2 of urfave cli.
There were two main breaking changes that I noticed.
First, command aliases must now be unique, whereas in v1 they were allowed and the earlier one was overridden. Tests had to be updated to take this into account.
Second, and more seriously, there are issues with v2 and flags occuring after arguments (see urfave/cli#1950 and its eventual fix urfave/cli#1987).
In short, it is no longer possible to do, for example,
ahoy main-cmd --help, it must beahoy --help main-cmd. Apprently this is fixed in v3, but v3 does not yet have a stable release. For the moment, I have updated the tests to deal with this.On a positive note, I have tested it and v2 does indeed fix #95, so thats good.
We will have to decide if migrating is worth it, noting that there are some issues, but that v1 is not recommended for new development.