Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor engine #367

Merged
merged 5 commits into from
Nov 29, 2024
Merged

Refactor engine #367

merged 5 commits into from
Nov 29, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Nov 29, 2024

This PR splits the WorkGraphEngine into five parts:

  • WorkGraphEngine
  • ContextManager
  • AwaitableManager
  • TaskManager
  • ErrorHandlerManager

@superstar54 superstar54 linked an issue Nov 29, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 87.48420% with 99 lines in your changes missing coverage. Please review.

Project coverage is 81.67%. Comparing base (5937b88) to head (3be40c6).
Report is 102 commits behind head on main.

Files with missing lines Patch % Lines
aiida_workgraph/engine/task_manager.py 89.04% 64 Missing ⚠️
aiida_workgraph/engine/awaitable_manager.py 82.52% 18 Missing ⚠️
aiida_workgraph/engine/context_manager.py 76.47% 8 Missing ⚠️
aiida_workgraph/engine/workgraph.py 79.31% 6 Missing ⚠️
aiida_workgraph/engine/error_handler_manager.py 92.68% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   75.75%   81.67%   +5.91%     
==========================================
  Files          70       65       -5     
  Lines        4615     4872     +257     
==========================================
+ Hits         3496     3979     +483     
+ Misses       1119      893     -226     
Flag Coverage Δ
python-3.11 81.60% <87.48%> (+5.94%) ⬆️
python-3.12 81.60% <87.48%> (?)
python-3.9 81.66% <87.48%> (+5.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 force-pushed the refactor_engine branch 2 times, most recently from eff6a43 to 37327d3 Compare November 29, 2024 19:04
@superstar54 superstar54 merged commit 18420cc into main Nov 29, 2024
8 checks passed
@superstar54 superstar54 deleted the refactor_engine branch November 29, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the engine
2 participants