Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model selection #63

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Model selection #63

merged 3 commits into from
Jun 27, 2023

Conversation

Roman223
Copy link
Collaborator

NOTE: This experimental feature was not covered by tests! Proceed with caution.

  1. Selection of model for predict method.
  2. Subset max shape changed to 2 to make some models working.

2. Subset max shape changed to 2 to make some models working.
@Roman223 Roman223 requested a review from Anaxagor June 27, 2023 13:00
Anaxagor
Anaxagor previously approved these changes Jun 27, 2023
Tests error fixed
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Merging #63 (f771e35) into master (b326e4f) will increase coverage by 4.56%.
The diff coverage is 78.77%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   60.81%   65.38%   +4.56%     
==========================================
  Files          28       32       +4     
  Lines        2067     2256     +189     
==========================================
+ Hits         1257     1475     +218     
+ Misses        810      781      -29     
Impacted Files Coverage Δ
bamt/networks/hybrid_bn.py 100.00% <ø> (ø)
bamt/nodes/logit_node.py 86.66% <0.00%> (+1.66%) ⬆️
bamt/utils/EvoUtils.py 63.09% <63.09%> (ø)
bamt/builders/hc_builder.py 69.44% <69.44%> (ø)
bamt/networks/base.py 48.62% <80.00%> (+5.19%) ⬆️
bamt/builders/evo_builder.py 96.92% <96.92%> (ø)
bamt/builders/__init__.py 100.00% <100.00%> (ø)
bamt/builders/builders_base.py 94.26% <100.00%> (ø)
bamt/nodes/__init__.py 100.00% <100.00%> (ø)
bamt/nodes/conditional_gaussian_node.py 89.42% <100.00%> (+3.84%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes

@Roman223 Roman223 merged commit 45c33e0 into master Jun 27, 2023
@Roman223 Roman223 deleted the model_selection_predict branch June 27, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants