Fix for #1296 #1312
Merged
Fix for #1296 #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All PEP8 errors has been fixed, thanks ❤️ Comment last updated at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1312 +/- ##
=======================================
Coverage 79.93% 79.94%
=======================================
Files 146 146
Lines 10097 10100 +3
=======================================
+ Hits 8071 8074 +3
Misses 2026 2026 ☔ View full report in Codecov by Sentry. |
DRMPN
reviewed
Jul 22, 2024
Lopa10ko
approved these changes
Jul 22, 2024
Lopa10ko
approved these changes
Jul 23, 2024
DRMPN
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
There was not enough copying for encoded categorical features during data spliting.
Fixes #1296