Skip to content

Commit

Permalink
Fix strict empty comparison for price
Browse files Browse the repository at this point in the history
  • Loading branch information
ain committed Nov 1, 2023
1 parent 9cc5f19 commit 3250409
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/smartbanner.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export default class SmartBanner {
}

get price() {
if (this.options.price && this.options.price != '') {
if (this.options.price && this.options.price !== '') {

Check failure on line 113 in src/smartbanner.js

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 20)

Expected indentation of 4 spaces but found 3

Check failure on line 113 in src/smartbanner.js

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 20)

Expected indentation of 4 spaces but found 3

Check failure on line 113 in src/smartbanner.js

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 18)

Expected indentation of 4 spaces but found 3

Check failure on line 113 in src/smartbanner.js

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 18)

Expected indentation of 4 spaces but found 3
return this.options.price;
} else {

Check failure on line 115 in src/smartbanner.js

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 20)

Expected indentation of 4 spaces but found 3

Check failure on line 115 in src/smartbanner.js

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 20)

Expected indentation of 4 spaces but found 3

Check failure on line 115 in src/smartbanner.js

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 18)

Expected indentation of 4 spaces but found 3

Check failure on line 115 in src/smartbanner.js

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 18)

Expected indentation of 4 spaces but found 3
return '';

Check failure on line 116 in src/smartbanner.js

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 20)

Expected indentation of 6 spaces but found 5

Check failure on line 116 in src/smartbanner.js

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 20)

Expected indentation of 6 spaces but found 5

Check failure on line 116 in src/smartbanner.js

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 18)

Expected indentation of 6 spaces but found 5

Check failure on line 116 in src/smartbanner.js

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 18)

Expected indentation of 6 spaces but found 5
Expand Down

0 comments on commit 3250409

Please sign in to comment.