Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small change to make the close button on iOS devices close button more accessible with color contrast. #702

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Small change to make the close button on iOS devices close button more accessible with color contrast. #702

merged 1 commit into from
Nov 27, 2023

Conversation

chriskim2311
Copy link

This is a small color change to the close button to make the banner more accessible with a better color contrast to the background light grey.

@coveralls
Copy link

Coverage Status

coverage: 93.798%. remained the same
when pulling c5ef558 on chriskim2311:contrast-close-button-color-change
into f6ee5be on ain:main.

@ain
Copy link
Owner

ain commented Nov 27, 2023

Thank you for the valuable contribution!

With this colour change the close button contrast ratio moves from 4.09:1 to 4.5:1 making it WCAG AA compliant.

@ain ain merged commit 9e2d3b2 into ain:main Nov 27, 2023
20 checks passed
@ain
Copy link
Owner

ain commented Nov 27, 2023

Released in v1.21.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ain ain ain approved these changes

Assignees
No one assigned
Labels
a11y enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriskim2311 @coveralls @ain