Skip to content

Fix IndexError on failure to close socket #241

Fix IndexError on failure to close socket

Fix IndexError on failure to close socket #241

Re-run triggered November 20, 2024 17:33
Status Failure
Total duration 3m 8s
Artifacts

ci-cd.yml

on: pull_request
Matrix: test
lint
21s
lint
Lint Commit Messages
13s
Lint Commit Messages
build_release
0s
build_release
test_release
0s
test_release
release
0s
release
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 1 warning
Lint Commit Messages
You have commit messages with errors ⧗ input: Fix IndexError on failure to close socket It is possible for `loop.sock_connect` to fail in such a way that the wrapped socket no longer refers to a valid file descriptor. In this, the exception handler can fail on the attempt to call `sock.close()`. When this happens, `start_connection` can have `sock == None` and `exceptions == []`. This causes an `IndexError` because it assumes that `exceptions` always contains at least one exception instance. ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Update impl.py Fix for type checker ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
test (3.8, macOS-latest)
[notice] A new release of pip is available: 21.1.1 -> 24.3.1 [notice] To update, run: python3.8 -m pip install --upgrade pip
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/