Update workflow to use upload-artifact v4 and download-artifact v4 #10281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #10281 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10281 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 122 122
Lines 37029 37029
Branches 2041 2041
=======================================
Hits 36579 36579
Misses 311 311
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
silamon
commented
Dec 31, 2024
webknjaz
requested changes
Dec 31, 2024
webknjaz
added
backport-3.11
psf-chronographer
bot
added
the
bot:chronographer:provided
webknjaz
approved these changes
Jan 1, 2025
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10288 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 1, 2025
This updates the CI/CD workflow to use the `upload-artifact` v4 and `download-artifact` v4 GitHub Actions. The currently used `upload-artifact` and `download-artifact` will no longer work at the end of next month. The changes are needed since v4 no longer has mutable artifacts, which was used to collect wheels from different architectures. Fixes #8588, fixes #8589, fixes #9009, fixes #10189, fixes #10191. PR #10281. (cherry picked from commit d54b3e2)
5 tasks
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10289 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 1, 2025
This updates the CI/CD workflow to use the `upload-artifact` v4 and `download-artifact` v4 GitHub Actions. The currently used `upload-artifact` and `download-artifact` will no longer work at the end of next month. The changes are needed since v4 no longer has mutable artifacts, which was used to collect wheels from different architectures. Fixes #8588, fixes #8589, fixes #9009, fixes #10189, fixes #10191. PR #10281. (cherry picked from commit d54b3e2)
5 tasks
webknjaz
pushed a commit
that referenced
this pull request
Jan 1, 2025
…ifact v4 and download-artifact v4 (#10289) **This is a backport of PR #10281 as merged into master (d54b3e2).** <!-- Thank you for your contribution! --> ## What do these changes do? This updates the ci/cd workflow to use the upload-artifact v4 and download-artifact v4 github actions. The currently used upload-artifact and download-artifact will no longer work at the end of next month. The changes are needed since v4 no longer has mutable artifacts, which was used to collect wheels from different architectures. Fix #8588, Fix #8589, Fix #9009, Fix #10189, Fix #10191 ## Are there changes in behavior for the user? No, the ci/cd workflow has been tested although without publishing. ## Related issue number <!-- Are there any issues opened that will be resolved by merging this change? --> <!-- Remember to prefix with 'Fixes' if it should close the issue (e.g. 'Fixes #123'). --> ## Checklist - [x] I think the code is well written - [ ] Unit tests for the changes exist - [ ] Documentation reflects the changes - [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [x] Add a new news fragment into the `CHANGES/` folder * name it `<issue_or_pr_num>.<type>.rst` (e.g. `588.bugfix.rst`) * if you don't have an issue number, change it to the pull request number after creating the PR * `.bugfix`: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations. * `.feature`: A new behavior, public APIs. That sort of stuff. * `.deprecation`: A declaration of future API removals and breaking changes in behavior. * `.breaking`: When something public is removed in a breaking way. Could be deprecated in an earlier release. * `.doc`: Notable updates to the documentation structure or build process. * `.packaging`: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions. * `.contrib`: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment. * `.misc`: Changes that are hard to assign to any of the above categories. * Make sure to use full sentences with correct case and punctuation, for example: ```rst Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`. ``` Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project. Co-authored-by: Simon Lamon <32477463+silamon@users.noreply.github.com>
webknjaz
pushed a commit
that referenced
this pull request
Jan 1, 2025
…ifact v4 and download-artifact v4 (#10288) **This is a backport of PR #10281 as merged into master (d54b3e2).** <!-- Thank you for your contribution! --> ## What do these changes do? This updates the ci/cd workflow to use the upload-artifact v4 and download-artifact v4 github actions. The currently used upload-artifact and download-artifact will no longer work at the end of next month. The changes are needed since v4 no longer has mutable artifacts, which was used to collect wheels from different architectures. Fix #8588, Fix #8589, Fix #9009, Fix #10189, Fix #10191 ## Are there changes in behavior for the user? No, the ci/cd workflow has been tested although without publishing. ## Related issue number <!-- Are there any issues opened that will be resolved by merging this change? --> <!-- Remember to prefix with 'Fixes' if it should close the issue (e.g. 'Fixes #123'). --> ## Checklist - [x] I think the code is well written - [ ] Unit tests for the changes exist - [ ] Documentation reflects the changes - [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [x] Add a new news fragment into the `CHANGES/` folder * name it `<issue_or_pr_num>.<type>.rst` (e.g. `588.bugfix.rst`) * if you don't have an issue number, change it to the pull request number after creating the PR * `.bugfix`: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations. * `.feature`: A new behavior, public APIs. That sort of stuff. * `.deprecation`: A declaration of future API removals and breaking changes in behavior. * `.breaking`: When something public is removed in a breaking way. Could be deprecated in an earlier release. * `.doc`: Notable updates to the documentation structure or build process. * `.packaging`: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions. * `.contrib`: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment. * `.misc`: Changes that are hard to assign to any of the above categories. * Make sure to use full sentences with correct case and punctuation, for example: ```rst Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`. ``` Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project. Co-authored-by: Simon Lamon <32477463+silamon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This updates the ci/cd workflow to use the upload-artifact v4 and download-artifact v4 github actions. The currently used upload-artifact and download-artifact will no longer work at the end of next month.
The changes are needed since v4 no longer has mutable artifacts, which was used to collect wheels from different architectures.
Fix #8588, Fix #8589, Fix #9009, Fix #10189, Fix #10191
Are there changes in behavior for the user?
No, the ci/cd workflow has been tested although without publishing.
Related issue number
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.